Never return undef from CallMethod, always return a response structure

with a valid error code. Makes handling in the caller more consistent.

Never return undef from CallMethod, always return a response structure
with a valid error code. Makes handling in the caller more consistent.
47a3e1ba · Leigh B Stoller · 98f55a64 · 47a3e1ba
Commit 47a3e1ba authored Oct 28, 2014 by Leigh B Stoller
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

protogeni/xmlrpc/Genixmlrpc.pm.in protogeni/xmlrpc/Genixmlrpc.pm.in +3 -2

No files found.
--- a/protogeni/xmlrpc/Genixmlrpc.pm.in
+++ b/protogeni/xmlrpc/Genixmlrpc.pm.in
@@ -182,8 +182,9 @@ sub CallMethod($$$@)
    }
    else {
 	print STDERR
-	    "Could not determine what version of FreeBSD you are running!\n";
-	return undef;
+	    "Could not determine what version of FreeBSD you are running!\n";	
+	return GeniResponse->new(GENIRESPONSE_RPCERROR, -1,
+	    "Could not determine what version of FreeBSD you are running!");
    }
    
    if ($FBSD_MAJOR >= 8) {