Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
emulab
emulab-devel
Commits
422ab906
Commit
422ab906
authored
Apr 19, 2004
by
Mike Hibler
Browse files
Minor stuff I forgot to checking
parent
6f5e8841
Changes
2
Hide whitespace changes
Inline
Side-by-side
os/imagezip/TODO
View file @
422ab906
...
...
@@ -10,7 +10,9 @@ Things to do for image*:
2. Imagezip could be multithread so that we can be reading ahead on the
input device and overlapping IO with compression. Maybe a third thread
for doing output.
for doing output. Input is a little tricky since imagezip shortens up
its reads as it gets near the end of a chunk, so the buffer mechanism
will have to handle having blocks only partially consumed.
3. In imagezip, split out the FS-specific code into subdirectories.
[DONE]
...
...
@@ -20,3 +22,6 @@ Things to do for image*:
5. Imageunzip could be triple-threaded like frisbee, i.e., split the
file reading and decompression that are currently one in imageunzip.
6. Create a "signature" file for an image using a collision-resistant hash
like MD5 or SHA-1. See TODO.hash for more.
os/imagezip/imagezip.c
View file @
422ab906
...
...
@@ -708,7 +708,7 @@ addskip(uint32_t start, uint32_t size)
{
struct
range
*
skip
;
if
(
size
<
frangesize
)
if
(
size
==
0
||
size
<
frangesize
)
return
;
if
((
skip
=
(
struct
range
*
)
malloc
(
sizeof
(
*
skip
)))
==
NULL
)
{
...
...
@@ -888,15 +888,15 @@ dumpranges(int verbose)
struct
range
*
range
;
uint32_t
total
=
0
;
if
(
verbose
)
{
if
(
verbose
)
fprintf
(
stderr
,
"
\n
Allocated ranges (start/size) in sectors:
\n
"
);
range
=
ranges
;
while
(
range
)
{
range
=
ranges
;
while
(
range
)
{
if
(
verbose
)
fprintf
(
stderr
,
" %12d %9d
\n
"
,
range
->
start
,
range
->
size
);
total
+=
range
->
size
;
range
=
range
->
next
;
}
total
+=
range
->
size
;
range
=
range
->
next
;
}
fprintf
(
stderr
,
"Total Number of Valid Sectors: %d (bytes %qd)
\n
"
,
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment