tbswap.in 42.8 KB
Newer Older
1 2 3 4
#!/usr/bin/perl -w

#
# EMULAB-COPYRIGHT
5
# Copyright (c) 2000-2005 University of Utah and the Flux Group.
6 7 8 9
# All rights reserved.
#
use English;

10 11 12
# Returns 0 on success.
# Returns 1 on non-assign_wrapper failure.
# Returns (1 | assign_wrapper's errorcode) on assign_wrapper failure.
13 14
# Returns |0x40 if update caused a swapout. Icky.
# Returns -1 on uncontrolled error (die called).
15

16 17 18 19 20
# XXX: handle error cases for update? (backup the db?)
# XXX: Shouldn't do idempotent stuff twice for update.
# XXX: repush/calc routing for update??? (tbprerun)
# XXX: previz for update???              (tbprerun)
# XXX: make snmpit faster for update.
Chad Barb's avatar
Chad Barb committed
21 22 23
#
# XXX: for update, expt is swapped out on os_setup fail.
#      (we only recover if assign fails)
24 25 26

sub usage()
{
27
    print STDERR "Usage: $0 -force { in | out | update [-reboot] [-eventsys_restart] } pid eid\n";
28 29 30 31 32 33 34
    exit(-1);
}

#
# Configure variables
#
my $TBROOT         = "@prefix@";
35
my $TBOPS          = "@TBOPSEMAIL@";
36 37
my $TESTMODE       = @TESTMODE@;
my $DISABLE_EVENTS = "@DISABLE_EVENT_SCHED@";
38
my $piper          = "$TBROOT/sbin/locpiper";
39 40 41 42 43 44 45 46 47 48 49

# Untaint the path
$ENV{'PATH'} = "/usr/bin:$TBROOT/libexec:$TBROOT/libexec/ns2ir" . 
    ":$TBROOT/sbin:$TBROOT/bin";

#
# Testbed Support libraries
#
use lib "@prefix@/lib";
use libdb;
use libtestbed;
50
use libadminctrl;
51
use libadminmfs;
52 53
use libtblog;

54
#require exitonwarn; # exitonwarn isn't really a module, so just require it
55 56 57 58

#
# Actual swap-in and swap-out functions, defined below.
#
59 60 61
sub doSwapout($);
sub doSwapin($);

62 63 64 65
#
# Firewall stuff
# XXX maybe should be elsewhere
#
66 67 68 69 70
sub FWSETUP()     { return 1; }
sub FWADDNODES()  { return 2; }
sub FWDELNODES()  { return 3; }
sub FWTEARDOWN()  { return 4; }
sub doFW($$$$);
71 72

# XXX fixme: should not be hardwired!
73
my $cnetstack = "-S Control";
74 75 76
my $cnetvlanname = "Control";


77 78 79 80
sub REAL()    { return 4; }
sub CLEANUP() { return 3; }
sub RETRY()   { return 2; }
sub UPDATE()  { return 1; }
Chad Barb's avatar
Chad Barb committed
81
sub UPDATE_RECOVER()  { return 0; }
82

83 84 85
#
# Grab global enable of linkdelays.
#
86
my $enablelinkdelays = TBGetSiteVar("general/linux_endnodeshaping");
87

88 89 90 91 92 93
#
# Turn off line buffering on output
#

$| = 1;

94 95
my $updateReboot   = 0;
my $updateReconfig = 1;
96 97
my $update_Eventsys_restart = 0;
my $elabinelab     = 0;
98 99
my $force  = 0;
my $errors = 0;
100
my $updatehosed = 0;
101
my $state;
102
my $canceled;
103 104
my $os_setup_pid;
my $cleanvlans;
105
my $nextState;
106 107

#
108
# First argument is either "in", "out", or "update";
109 110 111 112 113
# this value goes into $swapop.
#

my $swapop = shift;	

114 115 116 117
if (!$swapop || 
    (($swapop ne "in") && 
     ($swapop ne "out") &&
     ($swapop ne "update"))) {
118 119 120 121 122 123 124 125 126 127 128
    usage();
}

#
# Get other arguments.
#

while ($#ARGV > 1) {
    $arg = shift;
    if ($arg eq "-force") {
	$force = 1;
Chad Barb's avatar
Chad Barb committed
129 130
    } elsif ($arg eq "-reboot") {
	$updateReboot = 1;
131
	$updateReconfig = 0;
132 133 134
    } elsif ($arg eq "-noreconfig") {
	$updateReboot   = 0;
	$updateReconfig = 0;
135 136
    } elsif ($arg eq "-eventsys_restart" && $swapop eq "update") {
	$update_Eventsys_restart = 1;
137 138 139 140 141 142 143 144 145
    } else {
	usage();
    }
}
if ($#ARGV < 1) {
    usage();
}
my ($pid,$eid) = @ARGV;

146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161
#
# Untaint the arguments.
#
if ($pid =~ /^([-\@\w.]+)$/) {
    $pid = $1;
}
else {
    die("Tainted argument $pid!\n");
}
if ($eid =~ /^([-\@\w.]+)$/) {
    $eid = $1;
}
else {
    die("Tainted argument $eid!\n");
}

162 163 164 165 166 167
#
# Set Error reporting info
# 
tblog_set_info($pid,$eid,$UID);

#
168
# Turn on timestamps
169
#
170 171 172 173 174
TBDebugTimeStampsOn();

#
# Print starting message.
#
175 176
my $exptidx;
TBExptIDX($pid, $eid, \$exptidx);
177

178 179
print "Beginning swap-$swapop for $pid/$eid ($exptidx). " .
    TBTimeStampWithDate() . "\n";
180 181 182 183 184 185
TBDebugTimeStamp("tbswap $swapop started");

#
# Get experiment state; verify that experiment exists.
#
if (! ($state = ExpState($pid, $eid))) {
186
    tbdie "No such experiment $pid/$eid";
187
}
188 189 190
# Sanity check the current state. 
if (!$force) {
    if ($swapop eq "in") {
191
	tbdie("Experiment should be ACTIVATING. Currently $state.")
192
	    if ($state ne EXPTSTATE_ACTIVATING);
193
    }
194
    elsif ($swapop eq "out") {
195
	tbdie("Experiment should be SWAPPING. Currently $state.")
196
	    if ($state ne EXPTSTATE_SWAPPING);
197
    }
198
    elsif ($swapop eq "update") {
199
	tbdie("Experiment should be MODIFY_RESWAP. Currently $state.")
200
	    if ($state ne EXPTSTATE_MODIFY_RESWAP);
201 202
    }
}
203 204
# Get elabinelab status. See below.
if (! TBExptIsElabInElab($pid, $eid, \$elabinelab)) {
205
    tbdie("Could not get elabinelab status for experiment $pid/$eid");
206
}
207

208 209 210 211 212
#
# See if the experiment is firewalled
#
my $firewalled = TBExptFirewall($pid, $eid);

213 214 215
#
# Do actual swapping
#
216 217 218 219 220
if ($swapop eq "out") {
    #
    # Swap out
    #
    $errors = doSwapout(REAL);
221
}
222
elsif ($swapop eq "update") {
223 224 225 226 227 228 229 230 231 232 233 234 235 236
    #
    # Before swapout, do cursory admission control to see if the
    # modified experiment will be swappable. assign_wrapper does a
    # more stringent check using assign.
    #
    print STDERR "Checking with Admission Control ...\n";
    if (! TBAdmissionControlCheck($UID, $pid, $eid, undef)) {
	print STDERR "Admission control failure!\n";
	print "Failingly finished swap-$swapop for $pid/$eid. " .
	    TBTimeStamp() . "\n";
	TBDebugTimeStamp("tbswap $swapop finished (failed)");
	exit(1);
    }
    
237 238 239 240 241 242 243
    #
    # Update.
    #
    # Phase One -- swap experiment partially out.
    #
    print STDERR "Backing up physical state...\n";
    TBExptBackupPhysicalState($pid,$eid);
244

245
    $errors = doSwapout(UPDATE);
Chad Barb's avatar
Chad Barb committed
246

247
    if ($errors) {
248
	#
249 250 251 252 253
	# Clean up the mess, leaving the experiment in the SWAPPED state,
	# 
	print STDERR "Cleaning up after errors.\n";
	doSwapout(CLEANUP);
	$updatehosed = 1;
254
    }
255
    else {
256
	#
257
	# Phase Two -- swap experiment back in.
258
	#
Chad Barb's avatar
Chad Barb committed
259 260
	$errors = doSwapin(UPDATE);

261
	if ($errors) {
Chad Barb's avatar
Chad Barb committed
262 263 264
	    #
	    # There were errors; see if we can recover.
	    #
265
	    my $CanRecover = 1;
Chad Barb's avatar
Chad Barb committed
266 267 268

	    if ($errors != 7) {
		print STDERR "Update failure occurred _after_ assign phase; ";
269
		$CanRecover = 0;
Chad Barb's avatar
Chad Barb committed
270 271
	    }

272 273 274 275 276 277 278 279
	    if ($CanRecover) {
		print STDERR "Recovering virtual and physical state.\n";

		if (TBExptRemoveVirtualState($pid, $eid) ||
		    TBExptRestoreVirtualState($pid, $eid) ||
		    TBExptRestorePhysicalState($pid,$eid)) {
		    print STDERR "Could not restore backed-up state; ";
		    $CanRecover = 0;
Chad Barb's avatar
Chad Barb committed
280
		}
281 282 283 284 285 286 287
		else {
		    print STDERR "Doing a recovery swap-in of old state.\n";

		    if (doSwapin(UPDATE_RECOVER)) {
			print STDERR "Could not swap in old physical state; ";
			$CanRecover = 0;
		    }
Chad Barb's avatar
Chad Barb committed
288 289
		}
	    }
290 291 292 293 294 295 296

	    #
	    # Some part of the recovery failed; must swap it out. swapexp
	    # (caller) will then have to do more clean up, hence the special
	    # exit status indicated by $updatehosed.
	    # 
	    if (! $CanRecover) {
297
		print STDERR "Recovery aborted! Swapping experiment out.\n";
Chad Barb's avatar
Chad Barb committed
298
		doSwapout(CLEANUP);
299 300 301 302
		$updatehosed = 1;
	    }
	    else {
		print STDERR "Update recovery successful.\n";
Chad Barb's avatar
Chad Barb committed
303
	    }
304
	}
Chad Barb's avatar
Chad Barb committed
305 306
    }
}
307 308 309 310 311
elsif ($swapop eq "in") {
    #
    # Swap in
    #
    my $retries = 2;
312 313 314 315 316 317 318 319 320 321 322 323 324

    #
    # Before real swapin, do cursory admission control. assign_wrapper does
    # a more stringent check using assign.
    #
    print STDERR "Checking with Admission Control ...\n";
    if (! TBAdmissionControlCheck($UID, $pid, $eid, undef)) {
	print STDERR "Admission control failure!\n";
	print "Failingly finished swap-$swapop for $pid/$eid. " .
	    TBTimeStamp() . "\n";
	TBDebugTimeStamp("tbswap $swapop finished (failed)");
	exit(1);
    }
325 326
    
    $errors = doSwapin(REAL);
Chad Barb's avatar
Chad Barb committed
327

328 329 330 331 332 333 334 335 336 337
    #
    # Attempt a retry if: 
    #   a) there were errors, 
    #   b) doswapin() indicated (via return code 3) a retry is appropriate,
    #   c) we haven't tried too many times already.
    #   d) The cancelflag has not been set.
    #   e) $TESTMODE == 0.
    #
    while ($errors == 3 && $retries && !$canceled && !$TESTMODE) {
	$retries--;
338

339 340
	print STDERR "Cleaning up after errors; will try again.\n";
	doSwapout(RETRY);
341

342 343
	print STDERR "Trying again...\n";
	$errors = doSwapin(RETRY);
344
    }
345 346
    if ($errors || $canceled) {
	print STDERR "Cleaning up after " .
347
	    ($canceled ? "cancelation" : "errors") . ".\n";
348
	doSwapout(CLEANUP);
349 350 351 352 353 354 355
    }
}

#
# Write appropriate message and exit.
#
if ($errors) {
356
    print "Failingly finished swap-$swapop for $pid/$eid. ".TBTimeStamp()."\n";
357
    TBDebugTimeStamp("tbswap $swapop finished (failed)");
Chad Barb's avatar
Chad Barb committed
358

359 360
    # Pass out magic value to indicate that update failed!
    exit(1 | ($updatehosed ? 0x40 : 0));
361
}
362
print "Successfully finished swap-$swapop for $pid/$eid. " .TBTimeStamp()."\n";
363 364
TBDebugTimeStamp("tbswap $swapop finished (succeeded)");
exit(0);
365 366 367 368

#################################

##
Chad Barb's avatar
Chad Barb committed
369
#
370 371
# doSwapout - Swaps experiment out.
#
Chad Barb's avatar
Chad Barb committed
372
#             If in REAL or CLEANUP,
373 374 375
#             this function will free all nodes for the 
#             experiment.
#
Chad Barb's avatar
Chad Barb committed
376
#             If in RETRY or UDPATE,
377 378 379 380 381 382
#             only nodes not in RES_READY will be freed.
#
#             Returns 0 on success, >0 on failure.
#
##

383 384
sub doSwapout($) {
    my $type = shift; # REAL==4, CLEANUP==3, RETRY==2, UPDATE==1.
385 386 387 388 389 390 391 392 393 394 395
    my $swapout_errors = 0;

    #
    # wait for os_setup;
    # this only applies if called after a failed doswapin.
    #
    if ($os_setup_pid) {
	print "Waiting for os_setup to finish\n";
	waitpid($os_setup_pid, 0);
	undef $os_setup_pid;
    }
Chad Barb's avatar
Chad Barb committed
396

397
    if (! $TESTMODE) { 
398 399 400
	if (! ($DISABLE_EVENTS || $elabinelab)) {
	    if ($type >= RETRY ||
		($update_Eventsys_restart && $type == UPDATE) ) {
401 402
		print "Stopping the event system\n";
		if (system("eventsys_control stop $pid $eid")) {
403
		    tberror "Failed to stop the event system.";
404 405
		    $swapout_errors = 1;
		}
406 407 408 409 410 411 412

		#
		# Stop the location piper.
		#
		if (-x $piper) {
		    print "Stopping the location piper\n";
		    if (system("$piper -k $pid $eid")) {
413
			tberror "Failed to stop location piper.";
414 415 416
			$swapout_errors = 1;
		    }
		}
417 418
	    }
	}
419 420 421 422 423 424
	
	#
	# Do teardown of inner elab. We must do this before we teardown the
	# vlans since the inner control network is a vlan, and we want that
	# active so inner boss can reboot the inner nodes (avoid power cycle).
	#
425
	if ($elabinelab && $type >= CLEANUP) {
426 427
	    print "Tearing down elabinelab. This could take a while.\n";
	    if (system("elabinelab -k $pid $eid")) {
428
		tberror "Failed to teardown elabinelab!";
429 430 431 432
		$swapout_errors = 1;
	    }
	}

433
	#
Chad Barb's avatar
Chad Barb committed
434
	# Clean up any VLANs in experiment.
435
	#
436 437 438 439 440 441 442
	# When modifying an elabinelab experiment, leave the vlans intact
	# so that the inner networks are not suddenly disconnected!
	#
	if (! ($elabinelab && $type == UPDATE)) {
	    TBDebugTimeStamp("snmpit started");
	    print STDERR "Removing VLANs.\n";
	    if (system("snmpit -r $pid $eid")) {
443
		tberror "Failed to reset VLANs";
444 445 446 447 448
		$swapout_errors = 1;
	    } else {
		$cleanvlans = 0;
	    }
	    TBDebugTimeStamp("snmpit finished");
449
	}
450
    }
Chad Barb's avatar
Chad Barb committed
451

452 453 454
    if ($type >= CLEANUP) {
	#
	# We're not attempting a retry;
455
	#
456
	# Stop all of the vnodes.
457
	#
458
	if (! $TESTMODE) { 	
459 460 461
	    print "Tearing down virtual nodes.\n";
	    TBDebugTimeStamp("vnode_setup -k started");
	    if (system("vnode_setup -d -k $pid $eid")) {
462
		tberror "Failed to tear down vnodes.";
463 464 465
		$swapout_errors = 1;
	    }
	    TBDebugTimeStamp("vnode_setup finished");
466 467
	}

468 469 470 471 472 473 474
	#
	# Nodes behind a firewall are treated special.
	# See undoFWNodes for details.
	#
	if ($firewalled && undoFWNodes($pid, $eid)) {
	    return 1;
	}
Leigh B. Stoller's avatar
Leigh B. Stoller committed
475

476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498
	#
	# Perform swapout time admin actions.  Right now there is at most
	# one of these.  It isn't really a general mechanism, just a hook
	# for state saving or data collection during swapout.
	# A couple of important "fer now" notes:
	#
	#	We don't do this for firewalled experiments.  We need a way
	#	to "tag" the saved disk state to ensure it doesn't get
	#	instantiated outside of a firewall.
	#
	#	We only do this on REAL swapouts, and not on CLEANUPs.
	#	There are some types of CLEANUPs where we may want to
	#	do this, in particular an invocation caused by a failed
	#	modify operation, where the admin action is to save the
	#	experiment state.  So we will need to revisit this.
	#
	my %soaction = ();
	if ($type == REAL && !$firewalled) {
	    TBExptGetSwapoutAction($pid, $eid, \%soaction);
	}
	if ($soaction{'command'}) {
	    my @nodes = ExpNodes($pid, $eid, 1);

499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517
	    if (@nodes > 0) {
		print STDERR "Performing swapout admin MFS actions.\n";
		TBDebugTimeStamp("Performing swapout actions");
		my @failed = ();
		my %myargs = ();
		$myargs{'name'} = "tbswap";
		$myargs{'command'} = $soaction{'command'};
		if (defined($soaction{'timeout'})) {
		    $myargs{'timeout'} = $soaction{'timeout'};
		}
		$myargs{'timestamp'} = 1;
		if (TBAdminMfsRunCmd(\%myargs, \@failed, @nodes)) {
		    if ($soaction{'isfatal'}) {
			tberror
			    "Failed to run '" . $soaction{'command'} .
				"' on @failed!";
			return 1;
		    }
		    tbwarn
518 519
			"Failed to run '" . $soaction{'command'} .
			    "' on @failed!";
Leigh B. Stoller's avatar
Leigh B. Stoller committed
520 521
		}
	    }
522 523
	}

524 525
	#
	# remove all nodes from the experiment.
Chad Barb's avatar
Chad Barb committed
526
	# (nfree will send them to RES_FREE_DIRTY)
527 528 529 530
	#
	print STDERR "Freeing nodes.\n";
	TBDebugTimeStamp("nfree started");
	if (system("nfree $pid $eid")) {
531
	    tberror "Could not free nodes.";
532 533 534
	    $swapout_errors = 1;
	}
	TBDebugTimeStamp("nfree finished");
535 536 537 538 539

	#
	# Since this is an actual swapout, 
	# reset our count of swap out nag emails sent.
	#
540
	DBQueryWarn("update experiments set swap_requests='',sim_reswap_count='0' ".
541
		    "where eid='$eid' and pid='$pid'");
542 543
    } else {
	#
544
	# $type == RETRY or $type == UPDATE.
545 546
	# Therefore, don't deallocate nodes which have been successfully
	# incorporated into the experiment (i.e., are RES_READY).
Chad Barb's avatar
Chad Barb committed
547
	# (nfree will send deallocated nodes to RES_FREE_DIRTY)
548
	#
549 550 551 552 553 554 555 556
	my @failedpnodes = ();
	my @failedvnodes = ();
	
	my $db_result =
	    DBQueryFatal("select rv.node_id,n.allocstate,nt.isvirtnode ".
                         "  from reserved as rv ".
			 "left join nodes as n on n.node_id = rv.node_id ".
			 "left join node_types as nt on nt.type=n.type ".
557 558
			 "where rv.pid='$pid' and rv.eid='$eid'");

559
	while (my ($node,$allocstate,$isvirt) = $db_result->fetchrow_array) {
560
	    if ($allocstate ne TBDB_ALLOCSTATE_RES_READY()) {
561 562 563 564 565 566
		if ($isvirt) {
		    push(@failedvnodes, $node);
		}
		else {
		    push(@failedpnodes, $node);
		}
567 568 569
	    }
	}

570 571 572 573 574 575 576
	#
	# Tear down failed vnodes. Perhaps not needed?
	# 
	if (!$TESTMODE && @failedvnodes > 0) {
	    print "Tearing down failed virtual nodes.\n";
	    TBDebugTimeStamp("vnode_setup -k started");
	    if (system("vnode_setup -d -k $pid $eid @failedvnodes")) {
577
		tberror "Failed to tear down vnodes.";
578 579 580 581
		$swapout_errors = 1;
	    }
	    TBDebugTimeStamp("vnode_setup -k finished");
	}
582

583 584 585 586
	#
	# Release all failed nodes.
	# 
	if (@failedpnodes > 0 || @failedvnodes > 0) {
587 588
	    print STDERR "Freeing failed nodes.\n";
	    
589
	    TBDebugTimeStamp("nfree started");
Chad Barb's avatar
Chad Barb committed
590 591 592 593 594
	    #
	    # Specify -x switch so when a physical node gets freed,
	    # any virtual nodes (owned by this experiment)
	    # sitting on top of it are freed as well.
	    #
595 596
	    if (system("nfree -x $pid $eid " .
		       join(" ", (@failedpnodes, @failedvnodes)))) {
597
		tberror "Could not free nodes.";
598 599 600 601 602 603
		$swapout_errors = 1;
	    }
	    TBDebugTimeStamp("nfree finished");
	}
    }

604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627
    if (! $TESTMODE) {
	#
	# If the experiment has no Plab dslice nodes left, but still has
	# a Plab slice, destroy the slice
	#

	# Does the slice exist?
	$db_result =
	    DBQueryFatal("select slicename from plab_slices ".
			 "where pid='$pid' and eid='$eid'");

	if ($db_result->numrows) {
	    # Are there any dslice nodes left?
	    $db_result =
		DBQueryFatal("select n.node_id from nodes as n ".
			     "left join node_types as nt on n.type = nt.type ".
			     "left join reserved as r ".
			     " on r.node_id = n.node_id ".
			     "where r.pid='$pid' and r.eid='$eid' ".
			     " and nt.isplabdslice = 1");

	    if (!$db_result->numrows) {
		print "Destroying Planetlab slice.\n";
		TBDebugTimeStamp("plabslice destroy started");
628
		if (system("plabslice destroy $pid $eid")) {
629
		    tberror "Failed to destroy Plab dslice.";
630 631 632 633 634 635 636
		    $swapout_errors = 1;
		}
		TBDebugTimeStamp("plabslice destroy finished");
	    }
	}
    }

637 638 639 640 641 642 643 644
    if (! $TESTMODE) {
	#
	# All of these errors are non-fatal on swapout. We find out about them
	# via email sent from the individual scripts.
	#

	#
	# Only reset mountpoints if this is an actual swapout, and
645
	# not a failed swapin(cleanup), update, or retry.
646
	#
647
	if ($type == REAL) {
648 649 650
	    print "Resetting mountpoints.\n";
	    TBDebugTimeStamp("exports started");
	    if (system("exports_setup")) {
651
		tberror "Failed to reset mountpoints.";
652 653 654
	    }
	    TBDebugTimeStamp("exports finished");
	}
Chad Barb's avatar
Chad Barb committed
655

656 657 658 659
	#
	# Resetting named maps and email lists is fast and idempotent,
	# so whatever.
	#
660 661 662
	print "Resetting named maps.\n";
	TBDebugTimeStamp("named started");
	if (system("named_setup")) {
663
	    tbwarn "Failed to reset named map.";
664 665
	}
	TBDebugTimeStamp("named finished");
Chad Barb's avatar
Chad Barb committed
666

667 668
	print "Resetting email lists.\n";
	TBDebugTimeStamp("genelists started");
669
	if (system("genelists -t")) {
670
	    tbwarn "Failed to reset email lists.";
671 672 673 674
	}
	TBDebugTimeStamp("genelists finished");
    }

675
    #
676 677 678
    # Wipe the DB clean except during UPDATE or RETRY. In those
    #    cases, assign_wrapper will reset the DB after reading
    #    the info.
679
    #
680 681 682 683
    if ( $type >= CLEANUP ) {
	print STDERR "Resetting DB.\n";
	TBExptRemovePhysicalState( $pid, $eid );
    }
684 685 686 687 688

    return $swapout_errors;
}

##
Chad Barb's avatar
Chad Barb committed
689
#
690 691
# doSwapin - Swaps experiment in.
#
Chad Barb's avatar
Chad Barb committed
692 693 694 695 696
#            Returns:
#              0 - successful swapin
#              1 - failed swapin; cleanup required.
#              3 - failed swapin; cleanup required; can retry.
#              7 - failed swapin; assign failed; no cleanup.
697 698
##

699
sub doSwapin($) {
700 701 702
    my $type = shift; # REAL==4, RETRY==2, UPDATE==1, UPDATE_RECOVER=0.
    # Just the physnodes ...
    my @deleted_pnodes = ();
703

704 705 706 707 708
    #
    # assign_wrapper does all the virtual to physical mapping 
    # and updating the DB state.
    #

Chad Barb's avatar
Chad Barb committed
709
    if ($type > UPDATE_RECOVER) {
710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735
        #
        # Hacky test to allow disabling of linkdelays if the node is going
        # to run Linux. See sitevar above.
        #
	if (! $enablelinkdelays) {
	    $db_result =
		DBQueryFatal("select distinct e.pid,e.eid,vl.vnode,vn.osname ".
			 "  from experiments as e ".
			 "left join virt_lans as vl on vl.pid=e.pid and ".
			 "     vl.eid=e.eid ".
			 "left join virt_nodes as vn on vn.pid=e.pid and ".
			 "     vn.eid=e.eid and vn.vname=vl.vnode ".
			 "left join os_info as o on o.osname=vn.osname and ".
			 "  (o.pid=vl.pid or o.pid='" . TBOPSPID() . "') ".
			 "where (vl.uselinkdelay!=0 or e.uselinkdelays!=0 or ".
			 "       e.forcelinkdelays!=0) and ".
			 "     (o.os is NULL or o.os='Linux') and ".
			 "     e.pid='$pid' and e.eid='$eid'");

	    if ($db_result->numrows) {
		print "*** Endnodeshaping is disabled on Linux Images!\n";
		print "*** You must modify your experiment to swap it in.\n";
		return 1;
	    }
	}
	
Chad Barb's avatar
Chad Barb committed
736 737 738 739
	print "Mapping to physical reality ...\n";
	TBDebugTimeStamp("assign_wrapper started");

	#
740 741 742 743
	# Pass the -u (update) switch into assign_wrapper, which turns on
	# update mode. When doing a retry, must also fix the current nodes
	# to avoid stuff jumping around when simply trying to replace a node
	# that did not boot.
Chad Barb's avatar
Chad Barb committed
744 745
	#
	my $exitcode;
746 747 748
	my $wrapper = "assign_wrapper -u";
	$wrapper .= " -f"
	    if ($type == RETRY);
749
	
750
	if (system("$wrapper $pid $eid")) {
751 752
	    $exitcode = $? >> 8;

753
	    tberror "Failed ($exitcode) to map to reality.";
754

755 756
	    # Wrapper sets this bit when recovery is possible.
	    if ($exitcode & 64) {
757
		# We can recover. 
Chad Barb's avatar
Chad Barb committed
758
		return 7;
759 760
	    }
	    else {
761
		# No recovery, no retry.
Chad Barb's avatar
Chad Barb committed
762 763 764 765
		return 1;
	    }
	}
	TBDebugTimeStamp("assign_wrapper finished");
766

Chad Barb's avatar
Chad Barb committed
767 768
	print "Mapped to physical reality!\n";
    }
769

770
    # Check cancel flag before continuing. No retry, 
771
    TBGetCancelFlag($pid, $eid, \$canceled);
772 773 774
    return 1
	if ($canceled);

775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809
    #
    # Look for any nodes in RES_TEARDOWN. These need to be released,
    # and if a virtnode, they need to be torn down. We cannot wait for
    # the virtnodes to go down with the physnode they are hosted on,
    # so teardown and release the virtnodes first, and then do the
    # physnodes.
    #
    # Errors are fatal; no recovery or retry.
    #
    if ($type == UPDATE) {
	my $allocstate = TBDB_ALLOCSTATE_RES_TEARDOWN();
	
	$db_result =
	    DBQueryFatal("select r.node_id,nt.isvirtnode,nt.isremotenode ".
			 "  from reserved as r ".
			 "left join nodes as n on n.node_id=r.node_id ".
			 "left join node_types as nt on nt.type=n.type ".
			 "where r.pid='$pid' and r.eid='$eid' and ".
			 "      n.allocstate='$allocstate'");

	if ($db_result->numrows) {
	    my @virtnodes = ();
	    my @physnodes = ();
	    
	    print "Tearing down and releasing unused nodes\n";

	    # First teardown/release virtnodes. 
	    while (my ($node,$isvirt,$isrem) = $db_result->fetchrow_array()) {
		if ($isvirt) {
		    push(@virtnodes, $node);
		}
		elsif (!$isrem) {
		    push(@physnodes, $node);
		}
	    }
810 811 812
	    # See below.
	    @deleted_pnodes = @physnodes;
	    
813 814 815
	    if (@virtnodes) {
		TBDebugTimeStamp("vnode_setup started");
		
816
		if (system("vnode_setup -k $pid $eid @virtnodes")) {
817 818 819 820 821 822 823 824 825 826 827
		    print "Failed to tear down unused virtnodes!\n";
		    return 1;
		}
		TBDebugTimeStamp("vnode_setup finished");
		
		if (system("nfree $pid $eid @virtnodes")) {
		    print "Failed to nfree unused virtnodes!\n";
		    return 1;
		}
	    }
	    if (@physnodes) {
828 829 830
		if ($elabinelab) {
		    print "Removing nodes from inner elab.\n";
		    if (system("elabinelab -r $pid $eid @physnodes")) {
831
			tberror "Failed to remove inner nodes!";
832 833 834 835 836
			return 1;
		    }
		}

		#
837 838
		# If the experiment is firewalled, cleanup the nodes
		# we are releasing.
839
		# 
840
		if ($firewalled && undoFWNodes($pid, $eid, @deleted_pnodes)) {
841 842 843
		    return 1;
		}
		
844 845 846 847 848 849 850 851
		if (system("nfree $pid $eid @physnodes")) {
		    print "Failed to nfree unused physnodes!\n";
		    return 1;
		}
	    }
	}
    }

852 853 854 855 856 857
    # Exit here if we are testing.
    if ($TESTMODE) {
	print "Testing run - Stopping here.\n";
	return 0;
    }

858 859 860 861 862 863 864 865 866 867 868
    #
    # Handle tarballs - we might need to fetch some from URLs if the user
    # asked for that.
    #
    print "Fetching tarballs and RPMs (if any) ...\n";
    TBDebugTimeStamp("tarfiles_setup started");

    if (system("tarfiles_setup $pid $eid")) {
	#
	# No recovery for now - what would we do?
	#
869
	tberror "Failed to set up tarballs.";
870 871 872 873
	return 1;
    }
    TBDebugTimeStamp("tarfiles_setup finished");

874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901
    #
    # If there are any Plab dslice nodes in the experiment, create the
    # dslice now
    #
    if ($type > UPDATE_RECOVER) {
	# Are there any Plab nodes?
	$db_result =
	    DBQueryFatal("select n.node_id from nodes as n ".
			 "left join node_types as nt on n.type = nt.type ".
			 "left join reserved as r on r.node_id = n.node_id ".
			 "where r.pid='$pid' and r.eid='$eid' ".
			 " and nt.isplabdslice = 1");

	if ($db_result->numrows) {
	    # Does slice already exist?
	    $db_result =
		DBQueryFatal("select slicename from plab_slices ".
			     "where pid='$pid' and eid='$eid'");

	    if (! $db_result->numrows) {
		my @plabnodes = ();
		
		while (my ($node) = $db_result->fetchrow_array()) {
		    push(@plabnodes, $node);
		}
		
		print "Creating Planetlab slice.\n";
		TBDebugTimeStamp("plabslice create started");
902
		if (system("plabslice create $pid $eid")) {
903
		    tberror "Failed to create Plab dslice";
904 905 906 907 908 909 910
		    return 3;
		}
		TBDebugTimeStamp("plabslice alloc finished");
	    }
	}
    }

911
    # Check cancel flag before continuing. No retry, 
912
    TBGetCancelFlag($pid, $eid, \$canceled);
913 914 915
    return 1
	if ($canceled);

916 917 918 919 920 921 922 923 924
    #
    # These things need to get started before the nodes come up, so we'll
    # do them before the os_setup. Everything else can done in parallel with
    # os_setup. (Actually, these probably can too, since they should finish
    # long before the nodes reboot, but better safe than sorry)
    #
    print "Setting up mountpoints.\n";
    TBDebugTimeStamp("mountpoints started");
    if (system("exports_setup")) {
925
	tberror "Failed to setup mountpoints.";
926 927 928
	return 1;
    }
    TBDebugTimeStamp("mountpoints finished");
Chad Barb's avatar
Chad Barb committed
929

930 931 932
    TBDebugTimeStamp("named started");
    print "Setting up named maps.\n";
    if (system("named_setup")) {
933
	tbwarn "Failed to add node names to named map.";
934 935
	#
	# This is a non-fatal error.
Chad Barb's avatar
Chad Barb committed
936
	#
937 938
    }
    TBDebugTimeStamp("named finished");
Chad Barb's avatar
Chad Barb committed
939

940
    # Check cancel flag before continuing. No retry, 
941
    TBGetCancelFlag($pid, $eid, \$canceled);
942 943
    return 1
	if ($canceled);
Chad Barb's avatar
Chad Barb committed
944

945 946 947 948
    #
    # Setup any control-net firewall.
    # This must be done before reloading and rebooting nodes.
    #
949 950
    if ($firewalled && ($type == REAL || $type == UPDATE) &&
	doFW($pid, $eid, (($type == UPDATE) ? FWADDNODES : FWSETUP), undef)) {
951 952 953
	return 1;
    }

Chad Barb's avatar
Chad Barb committed
954 955
    #
    # If user specified -reboot to update,
956
    # and we are successfully performing the update,
957
    # then mark all nodes in experiment so os_setup will reboot them.
Chad Barb's avatar
Chad Barb committed
958
    #
959 960 961
    if (($type == UPDATE) &&
	($updateReboot || $updateReconfig)) {
	print STDERR "Marking nodes for reboot/reconfig.\n";
Chad Barb's avatar
Chad Barb committed
962
	$db_result =
963 964 965
	    DBQueryFatal("select r.node_id,n.allocstate from reserved as r ".
			 "left join nodes as n on n.node_id=r.node_id ".
			 "where r.pid='$pid' and r.eid='$eid'");
Chad Barb's avatar
Chad Barb committed
966

967 968 969 970 971 972 973 974
	while (my ($node,$allocstate) = $db_result->fetchrow_array) {
	    #
	    # If the node is INIT_CLEAN, leave it alone. It will still get
	    # rebooted, but will not falsely be tagged as dirty. This is
	    # important for vnodes too, where INIT_CLEAN indicated the vnode
	    # does not even exist yet (plab nodes).
	    #
	    if ($allocstate ne TBDB_ALLOCSTATE_RES_INIT_CLEAN()) {
975 976 977 978
		TBSetNodeAllocState($node,
				    ($updateReboot ?
				     TBDB_ALLOCSTATE_RES_INIT_DIRTY() :
				     TBDB_ALLOCSTATE_RES_RECONFIG()));
979
	    }
Chad Barb's avatar
Chad Barb committed
980 981 982
	}
    }

983 984 985 986 987
    #
    # Since it'll take a while for the nodes to reboot, we'll start now, and
    # wait for the os_setup to finish, down below
    #
    print "Resetting OS and rebooting.\n";
988
    TBDebugTimeStamp("launching os_setup");
989 990 991
    if (!($os_setup_pid = fork())) { 
	exec("os_setup $pid $eid") or return 1;
    } elsif ($os_setup_pid == -1) {
992
	tberror "Fork failed.";
993 994
	return 1;
    }
Chad Barb's avatar
Chad Barb committed
995

996
    #
997 998 999 1000 1001
    # XXX
    # Don't add any steps between here and the waitpid() call below
    # without verifying that 1) It's OK for nodes to come up before
    # the step has completed and 2) It's OK for the command to run in
    # parallel with os_setup (no DB dependencies, etc.)
1002 1003 1004 1005 1006
    #

    print "Setting up VLANs.\n";
    TBDebugTimeStamp("snmpit started");
    if (system("snmpit -t $pid $eid")) {
1007
	tberror "Failed to set up VLANs.";
1008 1009 1010
	return 1;
    }
    TBDebugTimeStamp("snmpit finished");
Chad Barb's avatar
Chad Barb committed
1011

1012 1013 1014 1015
    #
    # An error now means that the VLANS need to be cleaned up.
    #
    $cleanvlans = 1;
Chad Barb's avatar
Chad Barb committed
1016

1017 1018
    print "Setting up email lists.\n";
    TBDebugTimeStamp("genelists started");
1019
    if (system("genelists -t")) {
1020
	tbwarn "Failed to update email lists.";
1021 1022 1023 1024 1025
	#
	# This is a non-fatal error.
	# 
    }
    TBDebugTimeStamp("genelists finished");
Chad Barb's avatar
Chad Barb committed
1026

1027 1028 1029 1030 1031 1032 1033 1034
    #
    # Don't clear port counters on UPDATE.
    # (XXX should clear new nodes' port counters.)

    if ($type >= RETRY) {
	print "Clearing port counters.\n";
	TBDebugTimeStamp("portstats started");
	if (system("portstats -z -a -q $pid $eid")) {
1035
	    tbwarn "Failed to clear port counters.";
1036 1037 1038 1039 1040
	    #
	    # This is a non-fatal error.
	    # 
	}
	TBDebugTimeStamp("portstats finished");
1041
    }
Chad Barb's avatar
Chad Barb committed
1042

1043 1044 1045 1046 1047 1048 1049
    #
    # OK, let's see how that os_setup did
    #
    $kid = waitpid($os_setup_pid,0);
    if ($kid == $os_setup_pid) {
	undef $os_setup_pid; # Make sure doswapout() doesn't wait for it.
	if ($CHILD_ERROR) {
1050
	    tberror "Failed to reset OS and reboot nodes.";
1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064
	    #
	    # If there is a firewall involved, it could be that the
	    # firewall rules are preventing essential communication,
	    # so don't retry.
	    #
	    # XXX should only do this if the user has specified additional
	    # rules.  But right now, I may screw up too!
	    #
	    if ($firewalled) {
		print STDERR "Not retrying, ".
		    "firewall may be preventing setup.\n";
		return 1;
	    }

1065
	    #
1066 1067
	    # Use returncode from os_setup process to
	    # set global $retry flag, indicating to caller
1068 1069 1070
	    # that it may be beneficial to attempt
	    # a doSwapin() again.
	    #
1071
            if (($CHILD_ERROR >> 8) == 1) {
Chad Barb's avatar
Chad Barb committed
1072
		return 3;
1073 1074
	    } else {
		print STDERR "Not retrying due to error type.\n";
Chad Barb's avatar
Chad Barb committed
1075
		return 1;
1076
	    }
1077 1078 1079
	}
    } else {
	undef $os_setup_pid;
1080
	tberror "Error waiting for os_setup to finish.";
1081 1082 1083
	return 1;
    }
    TBDebugTimeStamp("os_setup finished");
Chad Barb's avatar
Chad Barb committed
1084

1085 1086 1087 1088
    #
    # Okay, start the event system now that we know all the nodes have
    # rebooted (os_setup is done). This only takes a moment (puts itself
    # in the background), so its not enough of a delay to worry about.
1089 1090
    # Don't do this during an update, since we didn't kill the 
    # event system previously, so starting it again will fail!
1091
    # 
1092
    if (! ($DISABLE_EVENTS || $elabinelab)) {
1093 1094 1095 1096 1097 1098 1099
	#
	# For the robot testbed, start the location piper *before* the event
	# system.
	#
	if (-x $piper && ($type != UPDATE && $type != UPDATE_RECOVER)) {
	    print "Starting the location piper.\n";
	    if (system("$piper $pid $eid")) {
1100
		tberror "Failed to start the location piper.";
1101 1102 1103 1104
		return 1;
	    }
	}
	
1105 1106
	if ( $update_Eventsys_restart || 
	    ($type != UPDATE && $type != UPDATE_RECOVER) ) {
1107 1108 1109
	    print "Starting the event system.\n";
	    TBDebugTimeStamp("eventsys_control started");
	    if (system("eventsys_control start $pid $eid")) {
1110
		tberror "Failed to start the event system.";
1111 1112 1113
		return 1;
	    }
	    TBDebugTimeStamp("eventsys_control finished");
1114 1115
	}
    }
Chad Barb's avatar
Chad Barb committed
1116

1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132
    #
    # Do linktest if user requested it at swapin.
    #
    my $query_result =
	DBQueryFatal("select linktest_level,linktest_pid from experiments ".
		     "where pid='$pid' and eid='$eid'");
    my ($linktest_level,$linktest_pid) = $query_result->fetchrow_array();
 
    if ($linktest_level && ($type == REAL || $type == UPDATE)) {
	if ($linktest_pid) {
	    print STDERR "*** Linktest is already running! $linktest_pid\n";
	}
	else {
	    #
	    # Run it. No worries about failures.
	    #
1133
	    my $optarg = "-l $linktest_level -t 600 -m";
1134 1135 1136 1137 1138 1139 1140 1141
    
	    print "Starting linktest ... this could take a while!'\n";
	    if (system("linktest_control $optarg $pid $eid") != 0) {
		print STDERR "*** Linktest run returned non-zero status!\n";
	    }
	}
    }

1142 1143 1144
    #
    # ElabinElab setup. This might not be the right place for this!
    #
1145 1146 1147
    if ($elabinelab && !$TESTMODE && ($type == REAL || $type == UPDATE)) {
	my $optarg = ($type == UPDATE ? "-u" : "");
	
1148 1149
	print "Setting up elabinelab. This could take a while!\n";
	TBDebugTimeStamp("elabinelab setup started");
1150
	if (system("elabinelab $optarg $pid $eid")) {
1151
	    tberror "Failed to setup elabinelab!";
1152 1153
	    return 1;
	}
1154
	TBDebugTimeStamp("ElabInElab setup finished");
1155 1156
    }

1157 1158 1159
    #
    # Tell the event scheduler to START.
    # 
1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170
    if (! ($DISABLE_EVENTS || $elabinelab)) {
	if ( $update_Eventsys_restart || 
	    ($type != UPDATE && $type != UPDATE_RECOVER) ) {
	    TBDebugTimeStamp("Starting event time");
	    if (system("tevc -e $pid/$eid now __ns_sequence start")) {
		print STDERR "*** Failed to start event time.\n";
		return 1;
	    }
	}
    }

1171 1172
    return 0;
}
1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184

#
# Setup and teardown experiment firewall.
#
# XXX note that right now, we just setup the switch infrastructure
# first, and then just let everything else go.  Firewalled nodes will
# not boot until the firewall is up since the VLAN is isolated til then.
# The firewall will boot ok since it still talks to the real control net.
#
# XXX for tearing down firewalls, we assume that nodes have been "cleansed"
# and it is safe to put ports back into the default control net VLAN.
#
1185 1186
sub doFW($$$$) {
    my ($pid, $eid, $action, $nodelist) = @_;
1187
    my ($fwnode, $fwvlanname, $fwvlan, $fwport, $fwvid);
1188
    my %nodenames;
1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201

    #
    # See if there is a firewall, fetching node/VLAN info if so.
    # If not, we are all done.
    #
    if (!TBExptFirewall($pid, $eid, \$fwnode, \$fwvid, \$fwvlan)) {
	return 0;
    }

    if ($action == FWSETUP) {
	$fwvid = TBGetUniqueIndex("cnet_vlanid");

	print "Setting up control net firewall.\n";
1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
    }
    else {
	if ($action == FWADDNODES) {
	    print "Adding nodes to control net firewall.\n";
	}
	elsif ($action == FWDELNODES) {
	    print "Removing nodes from control net firewall.\n";
	}
	else {
	    print "Tearing down control net firewall.\n";
	}
1213 1214 1215 1216 1217 1218 1219

	# Prior setup didn't succeed, nothing to do
	if (!defined($fwvid)) {
	    return 0;
	}
    }

1220 1221 1222 1223 1224 1225 1226
    # See below.
    if (defined($nodelist)) {
	foreach my $node (@$nodelist) {
	    $nodenames{$node} = $node;
	}
    }

1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237
    # XXX vlanid in the DB is currently an int, we need a more unique name
    $fwvlanname = "fw$fwvid";

    #
    # Find all the experiment nodes and their control interface switch ports
    #
    # XXX this may be replaced by a call to SNMPIT that just specifies
    # the pid/eid.  In that case someone else will first have to poplulate
    # the vlans table with this same info. 
    #
    my $db_result =
1238 1239 1240 1241 1242 1243
	DBQueryWarn("SELECT r.node_id,w.card1 ".
		    "  FROM wires AS w, reserved AS r ".
		    "WHERE r.node_id=w.node_id1 AND r.pid='$pid' ".
		    "  AND r.eid='$eid' AND w.type='Control'");
    return 1
	if (!$db_result);
1244 1245 1246

    my $portlist = "";
    while (my ($node,$cif) = $db_result->fetchrow_array()) {
1247
	print "$node $cif\n";
1248 1249
	if ($node eq $fwnode) {
	    $fwport = "$node:$cif";
1250 1251 1252 1253 1254 1255 1256 1257
	}
	elsif (defined($nodelist)) {
 	    print "foo @$nodelist\n";
	    # Only nodes we are moving in/out of the experiment.
	    $portlist .= " $node:$cif"
		if (exists($nodenames{$node}));
	}
	else {
1258 1259 1260 1261
	    $portlist .= " $node:$cif";
	}
    }
    if (!defined($fwport)) {
1262
	tberror "Firewall node '$fwnode' not found in $pid/${eid}!";
1263 1264 1265
	return 0;
    }
    if ($portlist eq "") {
1266 1267 1268 1269 1270
	#
	# We catch this up in swapexp; admin users can specify just a firewall,
	# but mere users must have at least one firewalled node. Just print
	# the warning though. 
	# 
1271
	tberror "No firewalled nodes in $pid/${eid}!";
1272 1273 1274 1275 1276 1277
    }

    #
    # XXX hack commands til we nail down the API
    #
    my $fwsetupstr1 = "snmpit $cnetstack -m $fwvlanname $portlist";
1278 1279
    my $fwsetupstr2 = "snmpit $cnetstack -N $fwvlanname";
    my $fwsetupstr3 = "snmpit $cnetstack -T $fwport $cnetvlanname $fwvlanname";
Leigh B. Stoller's avatar
Leigh B. Stoller committed
1280
    my $fwtakedownstr0 = "snmpit $cnetstack -e $fwport";
1281 1282
    my $fwtakedownstr1 = ($portlist eq "" ? "true" :
			  "snmpit $cnetstack -m $cnetvlanname $portlist");
1283 1284 1285 1286 1287 1288
    my $fwtakedownstr2 = "snmpit $cnetstack -o $fwvlanname";
    my $fwtakedownstr3 = "snmpit $cnetstack -U $fwport";
    my $fwtakedownstr4 = "snmpit $cnetstack -m $cnetvlanname $fwport";

    if ($action == FWSETUP) {
	TBDebugTimeStamp("snmpit firewall setup: VLAN");
1289
	print "doFW: '$fwsetupstr1'\n";
1290
	if (system($fwsetupstr1)) {
1291
	    tberror "Failed to setup Firewall control net VLAN.";
1292 1293
	    return 1;
	}
1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304
	#
	# XXX we don't need to rely on the format of the output of
	# the snmpit 
	#
	my @snmpit_out = split(' ', `$fwsetupstr2`);
	if ($? || @snmpit_out != 3 || $snmpit_out[2] !~ /^\d+$/) {
	    tberror "Could not get VLAN number for firewall VLAN, ".
		    "is your snmpit out of date?\n";
	    return 1;
	}
	my $fwvlan = $snmpit_out[2];
1305 1306

	TBDebugTimeStamp("snmpit firewall setup: trunk");
1307 1308
	print "doFW: '$fwsetupstr3'\n";
	if (system($fwsetupstr3)) {
1309
	    tberror "Failed to setup Firewall trunk on port $fwport.";
1310
	    if<