batch_daemon.in 17.9 KB
Newer Older
1
#!/usr/bin/perl -wT
Leigh B. Stoller's avatar
Leigh B. Stoller committed
2 3 4

#
# EMULAB-COPYRIGHT
5
# Copyright (c) 2000-2003 University of Utah and the Flux Group.
Leigh B. Stoller's avatar
Leigh B. Stoller committed
6 7 8
# All rights reserved.
#

9 10
use English;
use Getopt::Std;
11 12
use Fcntl;
use IO::Handle;
13 14 15 16 17 18

#
# Create a batch experiment.
#
# usage: batch_daemon
#
Leigh B. Stoller's avatar
Leigh B. Stoller committed
19 20
# TODO: Use "logger" instead of writing a log file.
#
21 22
sub usage()
{
23 24
    print STDOUT "Usage: batch_daemon [-d]\n" .
	"Use the -d option to prevent daemonization\n";
25 26
    exit(-1);
}
27
my  $optlist = "d";
28 29 30 31 32 33 34

#
# Configure variables
#
my $TB       = "@prefix@";
my $DBNAME   = "@TBDBNAME@";
my $TBOPS    = "@TBOPSEMAIL@";
35
my $TBLOGS   = "@TBLOGSEMAIL@";
36

37 38 39 40 41 42 43 44
#
# Only root can run this script.
#
if ($UID) {
    die("*** $0:\n".
	"    Only root can run this script!\n");
}

45 46 47 48 49 50 51
#
# Testbed Support libraries
#
use lib "@prefix@/lib";
use libdb;
use libtestbed;

52 53 54
# Be careful not to exit on transient error
$libdb::DBQUERY_MAXTRIES = 10;

55
my $tbbindir = "$TB/bin/";
56
my $swapexp  = "$TB/bin/swapexp";
57
my $endexp   = "$TB/bin/endexp";
58
my $savelogs = "$TB/bin/savelogs";
59
my $avail    = "$TB/sbin/avail";
60 61
my $batchlog = "$TB/log/batchlog";
my $projroot = "/proj";
62
my $debug    = 0;
63

64 65 66 67 68 69 70
my $BSTATE_POSTED	= EXPTSTATE_QUEUED;
my $BSTATE_ACTIVATING	= EXPTSTATE_ACTIVATING;
my $BSTATE_RUNNING	= EXPTSTATE_ACTIVE;
my $BSTATE_TERMINATING	= EXPTSTATE_TERMINATING;
my $BSTATE_PAUSED	= EXPTSTATE_SWAPPED;
my $BSTATE_LOCKED       = BATCHSTATE_LOCKED;
my $BSTATE_UNLOCKED     = BATCHSTATE_UNLOCKED;
71

72 73 74 75 76 77
#
# These are valid in the children, not the parent. I suppose I could use
# dynamically scoped variables, but hardly worth it.
#
my $eid;
my $pid;
Leigh B. Stoller's avatar
Leigh B. Stoller committed
78
my $gid;
79
my $logname;
Leigh B. Stoller's avatar
Leigh B. Stoller committed
80
my $nsfile;
81 82
my $userdir;
my $workdir;
83
my $user_name  = "Testbed Operations";
84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107
my $user_email = "$TBOPS";

#
# Turn off line buffering on output
#
$| = 1;

#
# Untaint the path
# 
$ENV{'PATH'} = "/bin:/usr/bin:";
delete @ENV{'IFS', 'CDPATH', 'ENV', 'BASH_ENV'};

#
# Parse command arguments. Once we return from getopts, all that should be
# left are the required arguments.
#
%options = ();
if (! getopts($optlist, \%options)) {
    usage();
}
if (@ARGV != 0) {
    usage();
}
108 109 110
if (defined($options{"d"})) {
    $debug = $options{"d"};
}
111 112

# Go to ground.
113
if (! $debug) {
114 115 116
    if (TBBackGround($batchlog)) {
	exit(0);
    }
117
}
118 119 120 121 122

#
# Loop, looking for batch experiments that want to run.
# 
while (1) {
123
    my($count, $i, $query_result, $pending_result, $running_result);
124
    my(%pending_row);
125 126 127 128 129
    my $retry_wait = TBGetSiteVar("batch/retry_wait");

    # Do not allow zero!
    $retry_wait = 60
	if ($retry_wait == 0);
Leigh B. Stoller's avatar
Leigh B. Stoller committed
130

131
    #
132
    # Need to lock the table here because of cancelation in endexp.
133 134 135 136 137 138
    # See the comments in there. We need to atomically grab the next
    # batch experiment we want to try, and then change its state from
    # new to configuring. We want to grab just one experiment, since
    # it takes a while to configure an experiment, and grabbing a bunch and
    # locking them up might result in having to wait a really long time
    # to cancel a batch experiment that hasn't really tried to start yet!
139
    # Thats would ne annoying to users.
140
    #
141
    # So, now you're wondering what my selection criteria is? Well, its
142 143
    # damn simplistic. I set the "started" datetime field each attempt,
    # and I pick the batch_experiment with the oldest time, thereby cycling
144 145 146 147
    # through in a "least recently attempted" manner. In addition, we want
    # to throttle the number simultaneous batches that one person can
    # can have running at a time (curently to just one batch), so check to
    # to see if the person has another batch active (thats e2 below).
148 149
    #
    $query_result =
150 151
	DBQuery("lock tables experiments write, experiments as e1 write, ".
		"experiments as e2 write");
152 153
    if (! $query_result) {
	print "DB Error locking tables. Waiting a bit ...\n";
Leigh B. Stoller's avatar
Leigh B. Stoller committed
154
	goto pause;
155 156 157
    }
    
    $pending_result =
158 159 160
	DBQueryWarn("SELECT e1.* FROM experiments as e1 ".
		    "left join experiments as e2 on ".
		    " e2.expt_head_uid=e1.expt_head_uid and ".
161
		    " e2.batchmode=1 and e2.state='$BSTATE_RUNNING' and ".
162 163 164
		    " e1.pid=e2.pid and e1.eid!=e2.eid ".
		    "WHERE e2.eid is null and ".
		    " e1.batchmode=1 and e1.canceled=0 and ".
165
		    " e1.expt_locked is null and ".
166
		    " e1.state='$BSTATE_POSTED' and ".
167 168
		    "  (e1.attempts=0 or ".
		    "    ((UNIX_TIMESTAMP() - ".
169
		    "      UNIX_TIMESTAMP(e1.expt_start) > ($retry_wait)))) ".
170
		    "ORDER BY e1.expt_start LIMIT 1");
171

172
    $running_result =
173
	DBQuery("select * from experiments ".
174
		"where batchmode=1 and state='$BSTATE_RUNNING' ".
175
		"ORDER BY expt_start LIMIT 1");
176 177 178

    if (!$pending_result || !$running_result) {
	print "DB Error getting batch info. Waiting a bit ...\n";
179
	DBQuery("unlock tables");
Leigh B. Stoller's avatar
Leigh B. Stoller committed
180
	goto pause;
181 182 183
    }

    if (!$pending_result->numrows && !$running_result->numrows) {
184
	DBQuery("unlock tables");
Leigh B. Stoller's avatar
Leigh B. Stoller committed
185
	goto pause;
186 187 188
    }

    #
189 190
    # If we have a pending experiment to run, the lock it right away,
    # while we have the tables locked. 
191
    #
192 193 194 195 196 197 198 199
    if ($pending_result->numrows) {
	%pending_row = $pending_result->fetchhash();

	# Local vars!
	my $eid = $pending_row{'eid'};
	my $pid = $pending_row{'pid'};

	$query_result = 
200
	    DBQuery("update experiments set ".
201
		    "       expt_locked=now(),expt_start=now() ".
202
		    "       batchstate='$BSTATE_LOCKED' ".
203
		    "where eid='$eid' and pid='$pid'");
204 205 206

	if (! $query_result) {
	    print "DB error setting batch $pid/$eid to configuring.\n";
207
	    DBQuery("unlock tables");
Leigh B. Stoller's avatar
Leigh B. Stoller committed
208
	    goto pause;
209 210
	}
    }
211

212 213 214 215 216 217 218 219 220 221 222
    #
    # Okay, first we check the status of running batch mode experiments
    # since we want to end those before trying to start any new ones, cause
    # it would be nice to have as many nodes available as possible before
    # trying to add a new one. This can potentially delay startup, but thats
    # okay. Its a batch system.
    #
    # If you are wondering why I check for finished experiments in the main
    # loop instead of in the child that started the experiment, its so that
    # we fire up again and look for them in the event that paper goes down.
    #
223 224 225 226
    if (!$running_result->numrows) {
	DBQueryWarn("unlock tables");
    }
    else {
227 228
	my %running_row = $running_result->fetchhash();
	my $canceled    = $running_row{'canceled'};
229 230 231
	# Local vars!
	my $eid         = $running_row{'eid'};
	my $pid         = $running_row{'pid'};
232

233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254
	#
	# Lock so user cannot mess with it.
	# 
	$query_result = 
	    DBQuery("update experiments set ".
		    "       expt_locked=now(), ".
		    "       batchstate='$BSTATE_LOCKED' ".
		    "where eid='$eid' and pid='$pid'");
	DBQueryWarn("unlock tables");

	if ($query_result) {
	    if ($canceled) {
		# Look at the cancel flag.
		if ($canceled == EXPTCANCEL_TERM) {
		    dosomething("cancel", %running_row);
		}
		elsif ($canceled == EXPTCANCEL_SWAP) {
		    dosomething("swap", %running_row);
		}
		else {
		    print "Improper cancel flag: $canceled\n";
		}
255 256
	    }
	    else {
257 258 259 260 261 262 263 264 265 266 267 268
		if (isexpdone(%running_row)) {
		    #
		    # Terminate the experiment. 
		    # 
		    dosomething("swap", %running_row);
		}
		else {
		    #
		    # Unlock.
		    # 
		    TBBatchUnLockExp($pid, $eid);
		}
269
	    }
270 271 272 273 274 275 276 277
	}
    }
    #
    # Finally start an actual experiment!
    #
    if ($pending_result->numrows) {
	dosomething("start", %pending_row);
    }
Leigh B. Stoller's avatar
Leigh B. Stoller committed
278
  pause:
279
    sleep(15);
280 281 282
}

#
283
# Do something as the user. Either, start, end, or cancel an experiment.
284
#
285
sub dosomething($$)
286
{
287 288
    my($dowhat)   = shift;
    my(%exphash)  = @_;
289
    my($unix_uid, $unix_gid, $unix_gname, $row, $query_result);
290 291

    # Global vars
292 293 294
    $eid     = $exphash{'eid'};
    $pid     = $exphash{'pid'};
    $gid     = $exphash{'gid'};
295 296
    $userdir = $exphash{'path'};
    $workdir = TBExptWorkDir($pid, $eid);
297 298 299 300
    $nsfile  = "$eid.ns";
    
    # Locals
    my $creator = $exphash{'expt_head_uid'};
301

302 303 304 305 306 307 308
    print "Doing a '$dowhat' to batch experiment $pid/$eid\n";

    #
    # Create a temporary name for a log file. We do this in the parent so
    # we can remove it when the child ends. The child could remove it, but
    # since it is open in the child, it has the tendency to stick around.
    #
309
    $logname = TBExptCreateLogFile($pid, $eid, "${dowhat}-batch");
310

311 312 313
    #
    # Start up a child to run the guts. The parent waits. If the
    # experiment configures okay, the parent can return to try something
314
    # else.
315 316 317
    #
    $childpid = fork();
    if ($childpid) {
318

319
	print TBDateTimeFSSafe() . "\n";
320 321
	print "Child PID $childpid started to $dowhat $pid/$eid\n";

322
	waitpid($childpid, 0);
Leigh B. Stoller's avatar
Leigh B. Stoller committed
323
	my $status = $? >> 8;
324

325
	print TBDateTimeFSSafe() . "\n";
Leigh B. Stoller's avatar
Leigh B. Stoller committed
326
	print "Child PID $childpid exited with exit status $status\n";
327

328
        #
329
        # Close the log file.
330 331
	# The exp dir might be gone if the batch was killed/canceled.
        #
332
	if (-e $userdir) {
333 334
	    TBExptCloseLogFile($pid, $eid);
	}
Leigh B. Stoller's avatar
Leigh B. Stoller committed
335
	return $status;
336
    }
337
    openlog($logname);
338 339
    TBExptSetLogFile($pid, $eid, $logname);
    TBExptOpenLogFile($pid, $eid);
340

341 342 343
    #
    # Get some user information. 
    #
344
    if (!UserDBInfo($creator, \$user_name, \$user_email)) {
345
	fatal("DB Error getting user information for uid $creator");
346
    }
347
    
348 349
    chdir("$workdir") or
	fatal("Could not cd into $workdir!");
350 351 352 353 354

    #
    # Figure out the unix uid/gid that the experiment configuration is
    # going to run as. 
    #
Leigh B. Stoller's avatar
Leigh B. Stoller committed
355
    (undef,undef,$unix_uid) = getpwnam($creator) or
356
	fatal("No such user $creator");
357 358
    TBGroupUnixInfo($pid, $gid, \$unix_gid, \$unix_gname) or
	fatal("No such group $pid/$gid");
359

360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379
    #
    # Need the entire group list for the user, cause of subgroups, and cause
    # thats the correct thing to do. Too bad perl does not have a getgrouplist
    # function like the C library.
    #
    my $glist = `id -G $creator`;
    if ($glist =~ /^([\d ]*)$/) {
	$glist = $1;
    }
    else {
	fatal("Unexpected results from 'id -G $creator': $glist");
    }
    #
    # Remove current group from glist, then add gid twice at the front
    # of the list. Order matters here, or we won't pick up all the
    # groups we need.
    #
    $glist =~ s/ ?\b$unix_gid\b ?//;
    $glist = $unix_gid . " " . $unix_gid . " " . $glist;

380 381 382
    #
    # Change the ownership of the log file before we flip.
    #
383 384
    chown($unix_uid, $unix_gid, $logname) or
	fatal("Could not chown $logname to $unix_uid/$unix_gid!");
385 386

    # Flip to the user. We never flip back.
387 388 389 390 391
    $GID            = $unix_gid;
    $EGID           = $glist;
    $EUID = $UID    = $unix_uid;
    $ENV{'USER'}    = $creator;
    $ENV{'LOGNAME'} = $creator;
392
    
393 394 395
    if ($dowhat eq "start") {
	startexp(%exphash);
    }
396 397
    elsif ($dowhat eq "swap") {
	swapexp(%exphash);
398 399
    }
    elsif ($dowhat eq "cancel") {
400
	cancelexp(%exphash);
401 402 403 404 405 406 407 408 409 410
    }
    exit(0);
}

#
# Try to start an experiment. Never returns.
# 
sub startexp($)
{
    my(%exphash)  = @_;
411
    my($exit_status, $running, $query_result);
412 413 414

    my $attempts  = $exphash{'attempts'};

415
    #
416
    # Try to swap the experiment in. 
417
    #
418
    system("$swapexp -b -s in $pid $eid");
419 420
    $exit_status = $? >> 8;
    $running     = 1;
421 422 423 424 425
    if ($exit_status) {
	$running = 0;
    }
    
    #
426 427
    # Look for cancelation. If we get a DB error on this, just continue cause
    # we can pick up the cancelation later.
428 429
    #
    $query_result =
430
	DBQueryWarn("select canceled from experiments ".
431
		    "where eid='$eid' and pid='$pid'");
432

433
    if ($query_result) {
434 435
	my ($canceled) = $query_result->fetchrow_array();
	$exphash{'canceled'} = $canceled;
436

437
	# Yuck: This is strictly for the benefit of swapexp() below.
438
	$exphash{'state'} = EXPTSTATE_ACTIVE
439 440 441 442
	    if ($running);
	
	if ($canceled) {
	    # Look at the cancel flag.
443
	    if ($canceled == EXPTCANCEL_TERM) {
444 445
		cancelexp(%exphash);
	    }
446
	    elsif ($canceled == EXPTCANCEL_SWAP) {
447 448 449 450 451
		swapexp(%exphash);
	    }
	    else {
		print "Improper cancel flag: $canceled\n";
	    }
452 453 454
	    #
	    # Never returns, but just to be safe ...
	    #
455
	    exit(-1);
456 457
	}
    }
458 459 460 461

    #
    # If the configuration failed for lack of nodes, then don't send
    # email unless the number of attempts starts to get big.
462
    #
463 464 465
    # If the configuration failed for some other reason, then send email.
    # We have to reset the state to "new" so that it will be retried again
    # later. 
466 467
    #
    if (! $running) {
468 469 470 471
	#
	# XXX - What if this update fails?
	# 
	$query_result = 
472
	    DBQueryWarn("update experiments set attempts=attempts+1 ".
473
			"where eid='$eid' and pid='$pid'");
474

475
	#
476 477 478 479
	# The exit value is important. If its -1 or 1, thats bad. Anything
	# else implies an assign violation that is (hopefully) transient.
	# We leave it up the user to kill the batch if it looks like its
	# never going to work.
480 481
	#
	if ($exit_status == 1 || $exit_status == -1) {
482
	    TBBatchUnLockExp($pid, $eid, EXPTSTATE_SWAPPED());
483
	    
484
	    email_status("Experiment startup has failed with a fatal error!\n".
485 486
			 "Batch has been dequeued so that you may check it.");

487
	    exit($exit_status);
488
	}
489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506
	
	if (($attempts % 30) == 0) {
	    $attempts++;

	    my $msg =
		"Could not configure Batch Mode experiment $pid/$eid.\n".
		"\n".
		"There was an assignment violation (please check the log)\n".
		"that prevented it from being scheduled. The violation\n".
		"might result from not enough nodes or not enough link\n".
		"bandwidth. If you feel that the violation is in error,\n".
		"please cancel the batch and notify $TBOPS\n".
		"Otherwise, another attempt will be made in a little while.\n".
		"\n". 
		"There have been $attempts attempts to start this batch.";

	    email_status($msg);
	}
507
	TBBatchUnLockExp($pid, $eid, EXPTSTATE_QUEUED());
508
	exit($exit_status);
509 510 511
    }

    #
512
    # Well, it configured! We can now unlock it.
513
    #
514
    TBBatchUnLockExp($pid, $eid);
515
    
516
    email_status("Batch Mode experiment $pid/$eid is now running!\n".
517
		 "Please consult the Web interface to see how it is doing.");
Leigh B. Stoller's avatar
Leigh B. Stoller committed
518

519
    #
520
    # Done with this phase. Must exit.
521
    #
522 523
    exit(0);
}
524

525
#
526
# A batch has completed. Swap it out. 
527
#
528
sub swapexp($;$)
529 530
{
    my(%exphash)  = @_;
531
    my $canceled  = $exphash{'canceled'};
532
    my $running   = ($exphash{'state'} eq EXPTSTATE_ACTIVE);
533

534 535 536 537 538 539 540 541
    if ($running) {
	system("$swapexp -b -s out $pid $eid");
	if ($?) {
	    #
	    # TB admin is going to have to clean up. 
	    # 
	    fatal("Swapping out Batch Mode experiment $pid/$eid");
	}
542 543 544 545 546
    }
    #
    # Set the state to paused to ensure that it is not run again until
    # the user wants to.
    # 
547 548
    TBSetCancelFlag($pid, $eid, EXPTCANCEL_CLEAR);
    TBBatchUnLockExp($pid, $eid);
549
    
550 551 552 553 554
    if ($canceled) {
	email_status("Batch Mode experiment $pid/$eid has been stopped!");
    }
    else {
	email_status("Batch Mode experiment $pid/$eid has finished!");
555
    }
556
   
557
    #
558
    # Child must exit!
559
    #
560 561 562 563 564 565
    exit(0);
}

#
# Cancel an experiment. Never returns.
#
566
sub cancelexp($)
567 568 569
{
    my(%exphash) = @_;
    
570 571 572 573
    #
    # It does not matter if the experiment is running; endexp does the
    # right thing.
    # 
574 575 576 577 578 579
    system("$endexp -b $pid $eid");
    if ($?) {
	#
	# TB admin is going to have to clean up. 
	# 
	fatal("Terminating Batch Mode experiment $pid/$eid");
580
    }
581
    donotify("Your Batch Mode experiment has been canceled!", "Canceled", 0);
582 583 584 585 586 587 588
   
    #
    # Child must exit!
    #
    exit(0);
}

589 590 591 592 593 594 595
#
# Check experiment status. Looks to see if all of the nodes in an
# experiment have reported in.
#
sub isexpdone($)
{
    my(%exphash)  = @_;
596
    my($query_result, @row);
597 598 599 600 601
    
    # Global vars
    $eid = $exphash{'eid'};
    $pid = $exphash{'pid'};

602
    print TBDateTimeFSSafe() . "\n";
603 604 605 606 607 608
    print "Checking to see if $pid/$eid has finished up yet\n";

    #
    # Look to see if any nodes yet to report status. If so, spin again.
    #
    $query_result =
609 610 611
	DBQueryWarn("SELECT startstatus,bootstatus FROM nodes ".
		    "LEFT JOIN reserved ON nodes.node_id=reserved.node_id ".
		    "WHERE reserved.eid='$eid' and reserved.pid='$pid'");
612 613 614 615 616

    if (! $query_result) {
	return 0;
    }

617 618 619 620 621 622 623 624 625 626 627 628 629
    #
    # Well, right now a node is considered finished up only if its
    # boot did not fail, and it has reported start command status.
    # The idea being that if the boot failed, then its status will
    # never be reported anyway, and we might as well consider the node
    # done (else the experiment would never end).
    # 
    while (@row = $query_result->fetchrow_array()) {
	if ($row[1] eq NODEBOOTSTATUS_FAILED) {
	    next;
	}
	if ($row[0] eq NODESTARTSTATUS_NOSTATUS) {
	    return 0;
630 631
	}
    }
632
    return 1;
633 634 635 636
}

#
# Start up a child, and set its descriptors talking to a log file.
Leigh B. Stoller's avatar
Leigh B. Stoller committed
637
# The log file already exists, created with mktemp above.
638 639 640 641 642 643 644
# 
sub openlog($)
{
    my($logname) = $_[0];
	
    #
    # We have to disconnect from the caller by redirecting both STDIN and
Leigh B. Stoller's avatar
Leigh B. Stoller committed
645 646
    # STDOUT away from the pipe. Otherwise the caller will continue to wait
    # even though the parent has exited. 
647 648
    #
    open(STDIN, "< /dev/null") or
649
	fatal("opening /dev/null for STDIN: $!");
650 651 652 653 654 655

    open(STDERR, ">> $logname") or
	fatal("opening $logname for STDERR: $!");
    open(STDOUT, ">> $logname") or
	fatal("opening $logname for STDOUT: $!");

656 657 658
    STDOUT->autoflush(1);
    STDERR->autoflush(1);

659 660 661
    return 0;
}

662 663 664 665 666
#
# A fatal error is something that the user does not need to know about.
# Caused by a breakdown in the TB system. Generally speaking, once the
# experiment is running, this should not be used.
# 
667
sub fatal($)
668 669 670
{
    my($mesg) = $_[0];

671
    donotify($mesg, "Failure", 1);
672 673 674 675

    exit(-1);
}

676 677 678
#
# Something the user cares about. 
# 
679
sub email_status($)
680
{
681
    my($mesg) = $_[0];
682

683
    donotify($mesg, "Status", 0);
684 685
}

686
sub donotify($$$)
687
{
688
    my($mesg, $subtext, $iserr) = @_;
689
    my($subject, $from, $to, $hdrs);
690
    my $MAIL;
691

692 693 694
    $mesg = "$mesg\n";

    print STDOUT "$mesg";
695

696
    $subject = "Batch Mode Experiment $subtext $pid/$eid";
697
    $from    = $TBOPS;
698 699 700 701 702 703
    $hdrs    = "Reply-To: $TBOPS";
    
    #
    # An error goes just to Testbed Operations. Normal status messages go
    # to the user and to the Testbed Logs address.
    # 
704
    if ($iserr) {
705
	$to = "$TBOPS";
706 707
    }
    else {
708 709 710
	$to   = "$user_name <$user_email>";
	$hdrs = "Bcc: $TBLOGS\n".
	        "$hdrs";
711 712
    }

713
    SENDMAIL($to, $subject, $mesg, $from, $hdrs,
714
	     ($logname, "assign.log", $nsfile));
715
}
716 717 718 719 720 721 722 723 724 725 726

sub TBBatchUnLockExp($$;$)
{
    my($pid, $eid, $newstate) = @_;

    DBQueryWarn("update experiments set expt_locked=NULL, ".
		"       batchstate='$BSTATE_UNLOCKED' ".
		(defined($newstate) ? ",state='$newstate' " : "") .
		"where eid='$eid' and pid='$pid'");
    return 1;
}